Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: cloudflared protocol option #135

Merged
merged 1 commit into from
Oct 17, 2024
Merged

add: cloudflared protocol option #135

merged 1 commit into from
Oct 17, 2024

Conversation

omegazeng
Copy link
Contributor

#72
use QUIC by default

add --set cloudflared.protocol=http2 to use HTTP2

@omegazeng
Copy link
Contributor Author

Hi @STRRL thank you for this amazing project.
the cloudflared has many flags, it may need another solution to support it.
for example:

cloudflared:
  extra-args:
  - --edge-ip-version
  - "6"
  - --protocol
  - http2

@STRRL
Copy link
Owner

STRRL commented Oct 17, 2024

LGTM Thanks!

BTW, about cloudflared customization, we're discussing in #128, feel free to leave comments if you have any other idea, or maybe hit 👍 if you think current proposal would work for you

@STRRL STRRL merged commit 649d5af into STRRL:master Oct 17, 2024
3 checks passed
@@ -77,3 +79,4 @@ cloudflared:
pullPolicy: IfNotPresent
tag: latest
replicaCount: 1
protocol: quic
Copy link
Contributor

@z0rc z0rc Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default must be auto, not quic. auto is quic with fallback to http2.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I would update it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I checked the Cloudflared docs, default is auto.
Weird. when I used the default config, it did not fallback to http2, and the tunnel did not work. I thought the default value was quic.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default protocol quic -> http2 updated in aa08f8b

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I checked the Cloudflared docs, default is auto. Weird. when I used the default config, it did not fallback to http2, and the tunnel did not work. I thought the default value was quic.

just curious, does explicitly setting cloudflared protocol to http2 work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants